Skip to content

Commit

Permalink
Forbid deprecated break-word in CSS (#30934)
Browse files Browse the repository at this point in the history
Forbid
[deprecated](https://drafts.csswg.org/css-text-3/#word-break-property)
`break-word` and fix all occurences.

Regarding `overflow-wrap: break-word` vs `overflow-wrap: anywhere`:

Example of difference: https://jsfiddle.net/silverwind/1va6972r/

[Here](https://stackoverflow.com/questions/77651244) it says:

> The differences between normal, break-word and anywhere are only clear
if you are using width: min-content on the element containing the text,
and you also set a max-width. A pretty rare scenario.

I don't think this difference will make any practical impact as we are
not hitting this rare scenario.
  • Loading branch information
silverwind committed May 10, 2024
1 parent 7424f27 commit 5556782
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion stylelint.config.js
Expand Up @@ -150,7 +150,7 @@ export default {
'declaration-property-unit-allowed-list': null,
'declaration-property-unit-disallowed-list': {'line-height': ['em']},
'declaration-property-value-allowed-list': null,
'declaration-property-value-disallowed-list': null,
'declaration-property-value-disallowed-list': {'word-break': ['break-word']},
'declaration-property-value-no-unknown': true,
'font-family-name-quotes': 'always-where-recommended',
'font-family-no-duplicate-names': true,
Expand Down
3 changes: 1 addition & 2 deletions web_src/css/features/console.css
Expand Up @@ -5,8 +5,7 @@
color: var(--color-console-fg);
font-family: var(--fonts-monospace);
border-radius: var(--border-radius);
word-break: break-word;
overflow-wrap: break-word;
overflow-wrap: anywhere;
}

.console img { max-width: 100%; }
Expand Down
1 change: 0 additions & 1 deletion web_src/css/helpers.css
Expand Up @@ -5,7 +5,6 @@ Gitea's private styles use `g-` prefix.

.gt-word-break {
word-wrap: break-word !important;
word-break: break-word; /* compat: Safari */
overflow-wrap: anywhere;
}

Expand Down
2 changes: 1 addition & 1 deletion web_src/css/repo.css
Expand Up @@ -410,7 +410,7 @@ td .commit-summary {
}

.repository.file.list .non-diff-file-content .plain-text pre {
word-break: break-word;
overflow-wrap: anywhere;
white-space: pre-wrap;
}

Expand Down
4 changes: 2 additions & 2 deletions web_src/css/shared/flex-list.css
Expand Up @@ -59,7 +59,7 @@
color: var(--color-text);
font-size: 16px;
font-weight: var(--font-weight-semibold);
word-break: break-word;
overflow-wrap: anywhere;
min-width: 0;
}

Expand All @@ -74,7 +74,7 @@
flex-wrap: wrap;
gap: .25rem;
color: var(--color-text-light-2);
word-break: break-word;
overflow-wrap: anywhere;
}

.flex-item .flex-item-body a {
Expand Down

0 comments on commit 5556782

Please sign in to comment.