Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Brown Out" when trying to connect to Microsoft DevOps Repos #1090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flocko-motion
Copy link

Microsoft introduced a "brownout" for SSH-RSA based authenticaction. In the future, only RSA-SHA2-256 and RSA-SHA2-512 are accepted. This does make a lot of sense, as the SHA-1 algorithm used for SSH-RSA authentication is not considered state of the art any more.

Details on SSH-RSA deprecaction:
https://devblogs.microsoft.com/devops/ssh-rsa-deprecation/

This patch changes the configuration of the SSH client to use RSA-SHA2-256 and RSA-SHA2-512 only. It's not advised to keep using SSH-RSA.

The fix caused by go-git based program to work again.

I'm very sorry for not providing a unit-test and detailled bug reports with this fix. It does work - I'm using it in production. It's also very tiny, so you might be able to accept it from a simple review.

Otherwise, please feed back to me and I'll try to provide more material, as soon as I find the time.

@pjbgf
Copy link
Member

pjbgf commented May 16, 2024

@flocko-motion thanks for your contribution. The changes could break existing setups, so ideally we need to provide a way for go-git users to change the HostKeyAlgorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants