Refactor pktline #1082
Open
Refactor pktline #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git file, git, and ssh transports use a full-duplex transport protocol. This is now located under `plumbing/transport`. The server transport along with its `Serve*` methods are now located under `plumbing/server`.
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Pktline is already implied in the package name, no need to have "Packet" in the method names.
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
aymanbagabas
force-pushed
the
transport-refactor-pktline
branch
from
1ec5a4c
to
33cd06f
Compare
pjbgf
reviewed
May 21, 2024
|
|
||
| // Make sure you close the server after the test. | ||
| func SetupProxyServer(c *C, handler http.Handler, isTls, schemaAddr bool) (string, *http.Server, net.Listener) { | ||
| httpListener, err := net.Listen("tcp", ":0") |
There was a problem hiding this comment.
This is to wide, we want to restrict the listening to the loopback interface.
Suggested change
| httpListener, err := net.Listen("tcp", ":0") | |
| httpListener, err := net.Listen("tcp", "127.0.0.1:0") |
| } | ||
|
|
||
| return true | ||
| s.n, s.err = Read(s.r, s.buf[:]) |
| return d.Decode(req) | ||
| } | ||
|
|
||
| type updReqDecoder struct { | ||
| r io.ReadCloser | ||
| s *pktline.Scanner | ||
| s io.Reader |
There was a problem hiding this comment.
The field s sounds confusing now that this is no longer a scanner.
Suggested change
| s io.Reader | |
| pr io.Reader |
| mtx sync.Mutex | ||
| ) | ||
|
|
||
| // Register adds or modifies an existing protocol. |
There was a problem hiding this comment.
Where the API changed substantially, I think we should either add comments to clarify that, or find another place to amass all the API changes, so it is easier for users to migrate to V6.
Suggested change
| // Register adds or modifies an existing protocol. | |
| // Register adds or modifies an existing protocol. | |
| // Equivalent to client.InstallProtocol in go-git before V6. |
Comment on lines
+17
to
+18
| defer mtx.Unlock() | ||
| registry[protocol] = c |
There was a problem hiding this comment.
When the code is this simple it is not worth the additional costs of a defer.
Suggested change
| defer mtx.Unlock() | |
| registry[protocol] = c | |
| registry[protocol] = c | |
| mtx.Unlock() |
Comment on lines
+24
to
+25
| defer mtx.Unlock() | ||
| delete(registry, scheme) |
There was a problem hiding this comment.
Suggested change
| defer mtx.Unlock() | |
| delete(registry, scheme) | |
| delete(registry, scheme) | |
| defer mtx.Unlock() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from aymanbagabas#1