Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for RU Center #1892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AntonDzyk
Copy link

No description provided.

@ldez ldez changed the title Add DNS provider for RU CENTER (#1891) Add DNS provider for RU CENTER Apr 12, 2023
@ldez
Copy link
Member

ldez commented Apr 12, 2023

Hello, in order for a PR adding a DNS provider to be accepted, you have to:

  • add a description to your PR
  • be able to maintain this provider
  • have a homogeneous design with the other providers
  • add tests (units)
make test
  • add tests ("live")
    func TestLivePresent(t *testing.T) {
    if !envTest.IsLiveTest() {
    t.Skip("skipping live test")
    }
    envTest.RestoreEnv()
    provider, err := NewDNSProvider()
    require.NoError(t, err)
    err = provider.Present(envTest.GetDomain(), "", "123d==")
    require.NoError(t, err)
    }
    func TestLiveCleanUp(t *testing.T) {
    if !envTest.IsLiveTest() {
    t.Skip("skipping live test")
    }
    envTest.RestoreEnv()
    provider, err := NewDNSProvider()
    require.NoError(t, err)
    time.Sleep(2 * time.Second)
    err = provider.CleanUp(envTest.GetDomain(), "", "123d==")
    require.NoError(t, err)
    }
make test
make generate-dns
  • be able to do: (and put the output of this command to a comment in your PR)
rm -rf .lego

./lego -m your@email.com --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

make checks
  • do go mod tidy

@ldez ldez self-requested a review April 12, 2023 12:06
@ldez ldez force-pushed the master branch 2 times, most recently from 5a203b9 to 4f9e9d4 Compare April 12, 2023 19:08
@ldez ldez changed the title Add DNS provider for RU CENTER Add DNS provider for RU Center Apr 12, 2023
@ldez
Copy link
Member

ldez commented Apr 12, 2023

Your PR was far away from the design of the other implementations, so I rewrite it and add tests on the client.

You can check my previous comment to know what are the next requirements.

@ldez
Copy link
Member

ldez commented Apr 13, 2023

ping @AntonDzyk

@ldez
Copy link
Member

ldez commented Apr 22, 2023

@AntonDzyk can you provide the missing information?
#1892 (comment)

@ldez ldez force-pushed the master branch 3 times, most recently from 19e63c8 to 1070f0d Compare May 5, 2023 08:38
@ldez
Copy link
Member

ldez commented May 15, 2023

ping @AntonDzyk

@ldez ldez added the state/need-user-tests Need users to test functionality label Jun 7, 2023
@ldez
Copy link
Member

ldez commented Jun 7, 2023

I'm still waiting for feedback @AntonDzyk.


If there is a user that wants to test this PR, you are welcome.

@ldez ldez mentioned this pull request Jun 27, 2023
8 tasks
@ldez ldez closed this in #1945 Jul 1, 2023
@ldez ldez reopened this Jul 1, 2023
@ldez ldez force-pushed the master branch 2 times, most recently from f6649ab to b848556 Compare February 7, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants