NSTableRowView class implementation #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcasa
changed the title
gcasa
changed the title
|
Work on this might result in refactoring some of the GSThemeDrawing stuff into NSTableView. The methods rowViewAtRow:... and viewAtColumn:row:... might be centric to this process as this seems the best place to manufacture whatever view should be displayed. Just noting this here as I am thinking about the implications of this change. |
gcasa
force-pushed
the
NSTableRowView_branch
branch
from
7e718b7
to
d3a0dd2
Compare
… outlineColumn drawing to a public method
…e uneeded private method
…ent is returned as nil
… happens in the correct place
|
@fredkiefer Please take a look at this and let me know. The changes clean up the code a great deal. |
|
@fredkiefer let me know what you think please. :) |
|
@fredkiefer Hey Fred, can you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of macOS since 10.7+ use an NSTableRowView to represent a row in NSTableView and it's subclasses when the table is view-based. This PR seeks to implement that functionality.