Whitelist UnexpectedException test for all architectures and recommend libunwind in INSTALL #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the other hand, automatic configuration is better than manually setting compile flags. |
|
What do you think @davidchisnall? |
|
I think this is the right thing (implicitly linking a non-default unwinded will break things for people), but I’d like CI to be green… |
We can use CompilerRT + libunwind in the CI |
|
I guess finding prebuild libunwind cross builds for ubuntu might be a bit difficult |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am undecided about whether to add a try_compile to the CMakeLists.txt to automatically use CompilerRT and libunwind if they are available. This should exclude Windows and Android.
This PR should be merged after a fix for libgcc: _Unwind_RaiseException corrupts return value is implemented in GCC.