AArch64 objc_msgSend: Fix argument corruption due to invalid stack pointer offset #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmelder
changed the title
davidchisnall
approved these changes
Jan 4, 2024
davidchisnall
approved these changes
Jan 4, 2024
|
What does using |
In the released versions of clang, nothing. In the next release, it will enable the fast-path dispatch for RV64. The recent clang fix also enabled it for other architectures in the correct library versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
We can run the tests with
-Xclang -fobjc-dispatch-method=non-legacy, but we would need to check for fast-path support in the CMake configuration first.