-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update driver install dir to follow cmake install prefix #1792
base: master
Are you sure you want to change the base?
Conversation
There seem to be build/test issues, I'll look into this. |
88d7bb6
to
89ce414
Compare
I've now reworked this whole thing. The basic idea is to always use the configurable I added some CMake statements to also be able to use built drivers from the build-dir directly in tests by copying the The logic should work for Gnu-install-dir-aware installations as well es MacOS, or Windows. I included some Clang-Tidy related changes as well. 😇 BTW: Are there any plans to include C++17, or C++20 dependent code? The return type of Best, Jan |
OMG, many thanks @jkohnert ! |
@GillesDuvert thanks for having a look at this. The failing tests were obviously unintended and I actually thought, I had fixed the problem. I'll have another look as soon as I have time. |
89ce414
to
33ee711
Compare
bac76ad
to
b53b4a7
Compare
When defining
GDL_LIB_DIR
, the install process does not take into account a setCMAKE_INSTALL_PREFIX
. I implemented this patch as part of the Arch-Linux AUR package, since having*.so
files in/usr/share/
is considered bad packaging by the Arch-Linux guidlines.Once applied, setting
GDL_LIB_DIR
is compatible toGDL_DATA_DIR
(f.e.lib/gnudatalanguage
, andshare/gnudatalanguage
), and both locations will respect a setCMAKE_INSTALL_PREFIX
(f.e/usr/
), so the install dirs will be f.e./usr/lib/gnudatalanguage
, and/usr/share/gnudatalanguage
, respectively.