-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Apple Silicon builds to CI (using macos-14 images); add WITH_OPENMP option to build_gdl.sh #1788
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
- Coverage 43.89% 43.72% -0.17%
==========================================
Files 376 376
Lines 97442 97401 -41
Branches 19888 19918 +30
==========================================
- Hits 42769 42589 -180
- Misses 54673 54812 +139 ☔ View full report in Codecov by Sentry. |
@slayoo seems that macos-14 has a problem with MPI? Not sure if it is indeed that, since compiling on Apple Silicon with OpenMP using our cmake/build_gdl.sh inevitably make gdl crash on a sigtrap. Only by removing OPENMP do the executable work. |
@GillesDuvert, indeed disabling OpenMP for Apple Silicon helps! Thanks! Now, we have only two tests failing there:
the first fails with:
the second with:
|
ah this will be easier to solve than the openMP parallel computing that Apple spent a lot of efforts to make crash on its products. |
@slayoo strange I have access to an M1, and these 2 test pass OK.
|
@alaingdl could you please check if |
No description provided.