New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix about ngx_http_upstream_fair_update_nreq #5

Open

atomd-zz wants to merge 1 commit into gnosek:master from atomd-zz:master

atomd-zz commented Jan 18, 2012

In #4

static void
ngx_http_upstream_fair_update_nreq(ngx_http_upstream_fair_peer_data_t *fp, int delta, ngx_log_t *log)
{
    #if (NGX_DEBUG)
    ...
    nreq = (fp->peers->peer[fp->current].shared->nreq += delta);
    total_nreq = (fp->peers->shared->total_nreq += delta);
    ...
    #endif
}

If there is no debug mode, ngx_http_upstream_fair_update_nreq has no effect.


          bug fix, ngx_http_upstream_fair_update_nreq has no effect with debug …

5320be7

…mode

Owner

gnosek commented Jan 30, 2012

Oops.

Does your patch compile cleanly with and without NGX_DEBUG? I'd be more comfortable with leaving the ifdef around ngx_log_debug.

aastaneh mentioned this pull request

Segfault in ngx_http_upstream_fair_walk_shm() #17

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment