Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 mouse is invisible even if hideCursor is false #1018

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harikattar
Copy link

x11Init assumes you're going to be hiding the mouse, so defines the cursor unconditionally.

FWIW the 'dot' cursor is always invisible on my system if it works at all.

I don't see a good way to fix this. The other option is to take the XDefineCursor call out of x11Init() entirely, and leave it up to the rest of the code if .SetPointer() should be used.

x11Init assumes you're going to be hiding the mouse, so defines the
cursor unconditionally.
@harikattar
Copy link
Author

FWIW I don't think this should be merged. It's crude, it exports more information across module boundaries and it's not obvious from looking at the source that LGDS_X11.setPointer() might not point to x11SetPointer(). It's mostly here to demonstrate the issue I'm having and a way to demo the desired behavior.

Fundamentally the issue here is that if we call setPointer() at any point we've taken charge of the pointer from the window manager. I think setting input:hideMouse=no (or a similar flag) should just leave it alone. There's only 7 callsites and a number of them are in the same function.

@gnif gnif marked this pull request as draft October 31, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant