Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install .desktop file and additional icon sizes for client #1011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snowkat
Copy link

@snowkat snowkat commented Jul 10, 2022

This installs "Looking Glass Client" to the System menu category along with various sizes of the icon.

@JJRcop
Copy link
Collaborator

JJRcop commented Jul 12, 2022

Should these images instead be generated using a source image and maybe something like imagemagick during make install?

@gnif
Copy link
Owner

gnif commented Jul 12, 2022

This is also the wrong icon, it needs updating to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.svg

@snowkat
Copy link
Author

snowkat commented Jul 13, 2022

Should these images instead be generated using a source image and maybe something like imagemagick during make install?

I converted them on my end to avoid having a build-time dependency on imagemagick. If dynamically generating them is preferred, I can modify the functionality for that.

This is also the wrong icon, it needs updating to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.svg

Good to know. Since SVG support is optional (per https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout), would it be safe to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.png in addition for systems which don't support SVG icons?

@gnif
Copy link
Owner

gnif commented Sep 18, 2022

I converted them on my end to avoid having a build-time dependency on imagemagick. If dynamically generating them is preferred, I can modify the functionality for that.

I don't think we need to do such a think, just simply re-generate them and commit them to the repository.

would it be safe to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.png in addition for systems which don't support SVG icons?

Yes provided it is updated first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants