Side orders from modals & refactoring #903

onemicky · 2024-04-08T13:43:54Z

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206545911703990

cloudflare-pages · 2024-04-10T18:55:19Z

Deploying gmx-interface with Cloudflare Pages

Latest commit:	`c70e90b`
Status:	✅ Deploy successful!
Preview URL:	https://b21a909a.gmx-interface.pages.dev
Branch Preview URL:	https://tpsl-from-modals-v2-rebased.gmx-interface.pages.dev

View logs

netlify · 2024-04-23T12:08:35Z

✅ Deploy Preview for vigilant-albattani-df38ec ready!

Name	Link
🔨 Latest commit	`ec54c99`
🔍 Latest deploy log	https://app.netlify.com/sites/vigilant-albattani-df38ec/deploys/66423e284bc83d0007b49424
😎 Deploy Preview	https://deploy-preview-903--vigilant-albattani-df38ec.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-04-23T12:08:36Z

✅ Deploy Preview for superb-tarsier-e2aa29 ready!

Name	Link
🔨 Latest commit	`ec54c99`
🔍 Latest deploy log	https://app.netlify.com/sites/superb-tarsier-e2aa29/deploys/66423e280aa22f0008fa4729
😎 Deploy Preview	https://deploy-preview-903--superb-tarsier-e2aa29.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gmxer · 2024-05-14T05:48:37Z

src/components/Synthetics/ConfirmationBox/ConfirmationBox.tsx


  function onCancelOrderClick(key: string): void {
    if (!signer) return;
    cancelOrdersTxn(chainId, signer, subaccount, {
      orderKeys: [key],
      setPendingTxns: p.setPendingTxns,
-      isLastSubaccountAction,


I remember it was needed for some subacc notification, isn't it needed anymore?

As i can see, now we don't use this param inside the function

gmxer · 2024-05-14T06:01:02Z

src/components/Synthetics/ConfirmationBox/ConfirmationBox.tsx


-    if (existingPosition || !entriesInfo) return;
+    if (!entriesInfo || !entriesInfo.entries.some((e) => e.txnType !== "cancel")) return;


would be slower but much more readable entriesInfo.entries.every((e) => e.txnType === "cancel")

Good suggestion, thanks

gmxer · 2024-05-14T06:07:30Z

src/components/Synthetics/ConfirmationBox/SidecarEntries.tsx

+
+  function handleAddEntry() {
+    addEntry();
+    setTimeout(() => {


requestAnimationFrame?

gmxer · 2024-05-14T06:09:34Z

src/components/Synthetics/ConfirmationBox/SidecarEntries.tsx

+
+  return (
+    <div className="SidecarEntries-wrapper" ref={containerRef}>
+      {displayableEntries?.map((entry) => {


Let's introduce <SidecarEntry key={..} entry={..} />?

Yap, good suggestion to improve

gmxer · 2024-05-14T06:11:12Z

src/components/Synthetics/ConfirmationBox/SidecarEntries.tsx

+
+                <NumberInput
+                  value={entry.price.input}
+                  onValueChange={(e) => updateEntry(entry.id, "price", e.target.value)}


you can memoize it in SidecarEntry component

gmxer · 2024-05-14T06:17:15Z

src/components/Synthetics/OrderList/OrderList.tsx

@@ -97,7 +92,6 @@ export function OrderList(p: Props) {
    cancelOrdersTxn(chainId, signer, subaccount, {
      orderKeys: [key],
      setPendingTxns: p.setPendingTxns,
-      isLastSubaccountAction,


same question, probably with same reason

answered on the first note

gmxer · 2024-05-14T06:23:09Z

src/components/Synthetics/StatusNotification/OrderStatusNotification.tsx

+      if (pendingOrder.txnType === "cancel") {
+        return Boolean(orderStatus?.cancelledTxnHash);
+      }
+      return false;


throw mustNeverExist(pendingOrder.txnType)

gmxer · 2024-05-14T06:27:32Z

src/components/Synthetics/StatusNotification/OrderStatusNotification.tsx

+
+function findMatchedOrderStatus(orderList: OrderStatus[], orderData: PendingOrderData) {
+  return orderList.find((status) => {
+    const isPendingOrderMatch = status.data && getPendingOrderKey(orderData) === getPendingOrderKey(status.data);


not a biggie but you can do getPendingOrderKey(orderData) outside of a loop

gmxer · 2024-05-14T07:57:28Z

src/domain/synthetics/sidecarOrders/utils.ts

+                : priceError
+              : inputPrice.lt(triggerPrice)
+              ? t`Price below Limit Price.`
+              : priceError;


these conditions looks very repetitive but don't have a strong idea what to do with it

Yep, it's a tricky place, hope it's a bit more readable now

gmxer · 2024-05-14T07:59:09Z

src/lib/useEffectOnce.ts

+  }, [effect]);
+}
+
+export default useEffectOnce;


this hook seems like a workaround, are you sure we need to re-use it somewhere else?

The problem forced me to create this helper was that i'm unable to set an initial state on a component mount when i use a centralized state & selectors. I agree that it's not a best solution. Ideally, we should maintain state independently of whether the component is mounted or not. But at the moment it makes code a bit more readable. I'll have no problem removing it when it will be no longer needed

midas-myth · 2024-05-14T16:09:04Z

src/components/Synthetics/StatusNotification/OrderStatusNotification.tsx

@@ -333,7 +334,7 @@ export function OrdersStatusNotificiation({
      if (pendingOrder.txnType === "cancel") {
        return Boolean(orderStatus?.cancelledTxnHash);
      }
-      return false;
+      throw mustNeverExist(pendingOrder.txnType);


i think throw is redundant because mustNeverExist already throws inside of it

Changes applyed, Midas checked

onemicky force-pushed the tpsl-from-modals-v2-rebased branch from d5f05b5 to 506b667 Compare April 11, 2024 11:45

Base automatically changed from selectors-refactoring-part-2.1 to release-22 April 16, 2024 09:21

onemicky changed the title ~~DON'T MERGE: tpsl from modals over refactoring~~ Side orders from modals & refactoring Apr 23, 2024

onemicky changed the base branch from release-22 to master April 23, 2024 12:06

onemicky force-pushed the tpsl-from-modals-v2-rebased branch from ae8858b to 334f2b7 Compare April 23, 2024 12:08

onemicky mentioned this pull request Apr 23, 2024

TP/SL from Modals: Part 2 #895

Closed

onemicky added 20 commits May 13, 2024 18:21

existing tpsl from modals

3c1a52d

refactoring

5028bb1

fix initial state

d535d89

fix price decimals

66f4395

fix limit orders tooltip

7429fc4

reduce size decimals

d9a0b31

fix pnl

b4e4806

fix sidecar collateral token

6522f22

fix error validation

6445ca2

fix limit price validation

2b694ef

fix decrease size with existing limits

c458bef

combined size tooltip

617e654

fix fitPercentage mode

1289b1a

fix limit price validation

3edcea7

a few more walidation fixes

370f812

rebuild

90c5cdf

tp sl price validation remake

30158dc

hide pnl for creating limit with existing position

1b84caf

fix subaccount required actions

d79a350

fix cancel newly created orders button

ec54c99

onemicky force-pushed the tpsl-from-modals-v2-rebased branch from 5231ad5 to ec54c99 Compare May 13, 2024 16:21

onemicky changed the base branch from master to release-26 May 13, 2024 16:22

onemicky added 2 commits May 13, 2024 22:33

remove temp labels

2ab65a1

fix min and max limit price

d49f752

gmxer previously requested changes May 14, 2024

View reviewed changes

onemicky added 3 commits May 14, 2024 10:44

fix wording

f06d7ed

fix sideorders revalidation

a130ba6

code review fixes

59391b6

midas-myth previously approved these changes May 14, 2024

View reviewed changes

remove throw

c70e90b

onemicky dismissed midas-myth’s stale review via c70e90b May 14, 2024 16:19

midas-myth approved these changes May 14, 2024

View reviewed changes

midas-myth requested a review from gmxer May 14, 2024 16:26

onemicky merged commit 7af2427 into release-26 May 14, 2024
1 check passed

midas-myth deleted the tpsl-from-modals-v2-rebased branch May 14, 2024 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Side orders from modals & refactoring #903

Side orders from modals & refactoring #903

onemicky commented Apr 8, 2024 •

edited

cloudflare-pages bot commented Apr 10, 2024 •

edited

netlify bot commented Apr 23, 2024 •

edited

netlify bot commented Apr 23, 2024 •

edited

gmxer May 14, 2024

onemicky May 14, 2024

gmxer May 14, 2024

onemicky May 14, 2024

gmxer May 14, 2024

gmxer May 14, 2024

onemicky May 14, 2024

gmxer May 14, 2024

gmxer May 14, 2024

onemicky May 14, 2024

gmxer May 14, 2024

gmxer May 14, 2024

gmxer May 14, 2024

onemicky May 14, 2024

gmxer May 14, 2024

onemicky May 14, 2024

midas-myth May 14, 2024


		if (existingPosition \|\| !entriesInfo) return;
		if (!entriesInfo \|\| !entriesInfo.entries.some((e) => e.txnType !== "cancel")) return;

Side orders from modals & refactoring #903

Side orders from modals & refactoring #903

Conversation

onemicky commented Apr 8, 2024 • edited

cloudflare-pages bot commented Apr 10, 2024 • edited

Deploying gmx-interface with Cloudflare Pages

netlify bot commented Apr 23, 2024 • edited

✅ Deploy Preview for vigilant-albattani-df38ec ready!

netlify bot commented Apr 23, 2024 • edited

✅ Deploy Preview for superb-tarsier-e2aa29 ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onemicky commented Apr 8, 2024 •

edited

cloudflare-pages bot commented Apr 10, 2024 •

edited

netlify bot commented Apr 23, 2024 •

edited

netlify bot commented Apr 23, 2024 •

edited