Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Update deployment manifests for k8s 1.16+ #629

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sesopenko
Copy link

@sesopenko sesopenko commented Dec 29, 2019

k8s 1.16+ no longer supports extensions/v1beta1 for DaemonSet and Deployment objects. The api versions for these have been updated to apps/v1 to match the documentation in kubernetes: DaemonSet, Deployment

selectors were added to the daemonset because the selector property is no longer optional.


This change is Reviewable

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@sesopenko
Copy link
Author

There appear to be build errors for most of the open PRs due to basename, dirname and python not being available in the CI image.

@freeeflyer
Copy link

Maybe you can add them in the .travis.yml ?

@sesopenko
Copy link
Author

Maybe you can add them in the .travis.yml ?

I'm running into other problems with the other templates, further down the process, too. If I run into time i can contribute some commits to a PR to correct some of these issues but I can't commit the time as of right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants