This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
more reliable passing of the complex tests #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New versions of Kubernetes' kubeadm do not have the --skip-preflight-check option anymore. It has been replaced with --ignore-preflight-errors. While testing, it seems this flag is not needed anymore, tests can continue without it. However, the updated Kubernetes versions seem more strict about the order of objects in the .yaml files. There are two instances where the Service refers to a Pod that is defined later on. This seems to prevent the Service from getting created. Moving the Service definition to the end, and tests pass again. See-also: kubernetes/kubernetes@3a0aa06
|
Can one of the admins verify this patch? |
|
@phlogistonjohn you mentioned something similar the other day? |
|
ok to test |
|
@nixpanic I did and yes that was probably the reason for the failure. Since I was under time pressure to test I just used an older version of k8s by editing the global_vars file. |
|
On Thu, Oct 04, 2018 at 02:34:50PM +0000, John Mulligan wrote:
@nixpanic I did and yes that was probably the reason for the failure. Since I was under time pressure to test I just used an older version of k8s by editing the global_vars file.
Did you test with any older versions, say one version back from latest?
No, I did not try with an older version... If that is a feature we want
to support, it'll get a little more difficult to implement.
|
|
We've generally tried to keep things somewhat backwards-compatible, especially for being able to switch between latest and latest-1. There are some spots where we do version checking that you could use to see if it wouldn't be too bad. |
|
So what's the take on this? |
obnoxxx
reviewed
Oct 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of Kubernetes' kubeadm do not have the
--skip-preflight-check option anymore. It has been replaced with
--ignore-preflight-errors. While testing, it seems this flag is not
needed anymore, tests can continue without it.
However, the updated Kubernetes versions seem more strict about the
order of objects in the .yaml files. There are two instances where the
Service refers to a Pod that is defined later on. This seems to prevent
the Service from getting created. Moving the Service definition to the
end, and tests pass again.
See-also: kubernetes/kubernetes@3a0aa06
This change is