Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed colour issue(logo) #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steveoo-tech
Copy link

Hopefullt this helps

@cseas
Copy link
Member

cseas commented Oct 30, 2020

Looks great! Please change logo192 and logo512 as well and modify the manifest file if needed.
All files to be changed are here.

I think the favicon needs to be changed too.

@aa-deet-eeya @shreyaraj13 Please take a look on what needs to be changed exactly. The "logo" file being used in the website is not present in the manifest anywhere, and the icons present in the manifest are all CRA defaults. There's a disconnection here. The manifest file should point to the logos that we use.

Reference

@cseas cseas linked an issue Oct 30, 2020 that may be closed by this pull request
@shreyaraj13
Copy link
Member

Looks good to me!

Icons that need to be changed are
• Colour of GWOC.png
• logo192.png which will be same as logo.png but of size 192x192
• logo512.png which will also be same as logo.png but of size 512x512
• favicon icon

Manifest.json requires the icons mentioned above to be modified.

@aa-deet-eeya aa-deet-eeya added the waiting-for-author Waiting for response from author label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-author Waiting for response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to change colour of the GWOC icon
4 participants