Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to change colour of the GWOC icon #24

Open
shreyaraj13 opened this issue Oct 28, 2020 · 4 comments · May be fixed by #34
Open

Need to change colour of the GWOC icon #24

shreyaraj13 opened this issue Oct 28, 2020 · 4 comments · May be fixed by #34
Assignees
@steveoo-tech
Labels
bug Something isn't working
Projects
Kanban

Comments

@shreyaraj13
Copy link
Member

The GWOC icon is only visible in the dark mode. Need to change the colour of it or give it a background.

iconissue1
iconissue2
WhatsApp Image 2020-10-28 at 10 20 32 (1)
WhatsApp Image 2020-10-28 at 10 20 32
@aa-deet-eeya
Copy link
Member

We might require a black border to make this more visible

@cseas cseas added the bug Something isn't working label Oct 29, 2020
@cseas cseas added this to To do in Kanban via automation Oct 29, 2020
@steveoo-tech
Copy link

I can work on this issue

@aa-deet-eeya
Copy link
Member

@steveoo-tech Thanks a lot for working on this!!
I think we should go with a bit darker version of blue or white color with a black border so that it matches with the theme of the website. Also there's GWOC.png which is currently not being used but I think we might use that in near future.
@cseas, what do you think?

@cseas
Copy link
Member

cseas commented Oct 30, 2020 •
edited

There could be multiple solutions to this:

  • Use a different color icon, like blue or orange, which would be visible on both black and white backgrounds.
  • Have 2 versions of the icon, one black and one white. But that probably won't work for this Issue since I'm not sure if you can trigger an icon change based on user theme.
  • Put a border around the icon which solves the visibility issue for white background.

@cseas cseas linked a pull request Oct 30, 2020 that will close this issue
fixed colour issue(logo) #34
Open
@cseas cseas moved this from To do to In Review in Kanban Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steveoo-tech steveoo-tech

Labels
bug Something isn't working
Projects
Kanban
In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed colour issue(logo) steveoo-tech/gwoc
4 participants
@aa-deet-eeya @cseas @steveoo-tech @shreyaraj13