Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with cube collapsing when 2-d and 3-d datasets were mixed in the image viewer #2188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Member

This still needs a changelog entry

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #2188 (1b7858a) into master (538b5f3) will decrease coverage by 0.01%.
The diff coverage is 92.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   88.05%   88.03%   -0.02%     
==========================================
  Files         247      247              
  Lines       23161    23040     -121     
==========================================
- Hits        20394    20284     -110     
+ Misses       2767     2756      -11     
Impacted Files Coverage Δ
glue/core/fixed_resolution_buffer.py 87.70% <0.00%> (-0.82%) ⬇️
glue/core/link_manager.py 97.64% <ø> (ø)
glue/plugins/coordinate_helpers/deprecated.py 44.44% <0.00%> (ø)
glue/app/qt/application.py 78.57% <50.00%> (ø)
glue/plugins/wcs_autolinking/wcs_autolinking.py 96.75% <95.45%> (ø)
glue/core/coordinates.py 90.62% <100.00%> (ø)
glue/core/data_factories/fits.py 88.88% <100.00%> (ø)
glue/plugins/coordinate_helpers/link_helpers.py 100.00% <100.00%> (ø)
glue/viewers/common/viewer.py 90.83% <100.00%> (ø)
glue/viewers/image/state.py 91.09% <100.00%> (+0.02%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a897a52...1b7858a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant