Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-recursive composite subsets #2140

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jsub1
Copy link
Contributor

@jsub1 jsub1 commented May 13, 2020

Fix for #1348. This PR adds a helper function that allows traversing the state tree in composite subset states without making recursive function calls.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #2140 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   87.99%   87.86%   -0.13%     
==========================================
  Files         245      246       +1     
  Lines       22322    22685     +363     
==========================================
+ Hits        19642    19932     +290     
- Misses       2680     2753      +73     
Impacted Files Coverage Δ
glue/core/subset.py 89.57% <100.00%> (+0.27%) ⬆️
glue/core/fixed_resolution_buffer.py 88.52% <0.00%> (-6.12%) ⬇️
glue/utils/array.py 89.49% <0.00%> (-5.86%) ⬇️
glue/core/component.py 91.28% <0.00%> (-5.78%) ⬇️
glue/viewers/image/python_export.py 86.53% <0.00%> (-4.64%) ⬇️
glue/viewers/matplotlib/state.py 90.18% <0.00%> (-3.94%) ⬇️
glue/viewers/matplotlib/layer_artist.py 95.55% <0.00%> (-1.89%) ⬇️
glue/viewers/matplotlib/viewer.py 93.92% <0.00%> (-1.36%) ⬇️
glue/core/data.py 90.22% <0.00%> (-0.90%) ⬇️
glue/viewers/profile/layer_artist.py 95.09% <0.00%> (-0.74%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656ddb7...e112a4a. Read the comment docs.

@astrofrog
Copy link
Member

astrofrog commented May 15, 2020

I'll try reviewing this soon, but in the mean time, could you fix the code style issues and also add a regression test that would normally have failed due to a recursion error?

@astrofrog astrofrog self-requested a review May 15, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants