Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Lines for table layers #96

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Carifio24
Copy link
Member

The goal of this PR is to implement a feature request from Alyssa, which is to have the ability to join points in a table layer with a line. This is done via the add_line functionality from the WWT client (JS-side, this uses WWT's PolyLine annotation).

There are a few outstanding issues:

  • This doesn't yet work in the Milky Way mode
  • The opacity of the lines is currently always 1. This is due to a WWT bug which was fixed upstream in Respect opacity when drawing annotations WorldWideTelescope/wwt-webgl-engine#238 but hasn't yet propagated down to pywwt.
  • The lines are added one at a time. This is usually not an issue since it happens quickly, but can become noticeable with a large number of points. If you play the video below at a slower speed (or just scrub to an appropriate frame), this can be seen. I think this is due to the fact that we can only add one line to the annotation at a time. I don't think this is as critical as the opacity, but is something I can look into.
TableLines.mov

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 56.00% and project coverage change: -0.47 ⚠️

Comparison is base (02379d0) 71.55% compared to head (76f8440) 71.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   71.55%   71.09%   -0.47%     
==========================================
  Files          18       18              
  Lines         872      896      +24     
==========================================
+ Hits          624      637      +13     
- Misses        248      259      +11     
Impacted Files Coverage Δ
glue_wwt/viewer/table_layer.py 74.72% <56.00%> (-2.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant