Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility of .ui files with Qt6 #93

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

astrofrog
Copy link
Member

Things still don't work properly with Qt6 due to WorldWideTelescope/pywwt#343 but I think this fixes the issues on our side.

@astrofrog astrofrog added the bug Something isn't working label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 74.79% // Head: 71.55% // Decreases project coverage by -3.23% ⚠️

Coverage data is based on head (5930232) compared to base (7f4f796).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   74.79%   71.55%   -3.24%     
==========================================
  Files          18       18              
  Lines         853      872      +19     
==========================================
- Hits          638      624      -14     
- Misses        215      248      +33     
Impacted Files Coverage Δ
glue_wwt/viewer/tools.py 50.94% <0.00%> (-30.19%) ⬇️
glue_wwt/viewer/image_style_editor.py 63.63% <0.00%> (-11.37%) ⬇️
glue_wwt/viewer/tests/test_wwt_widget.py 97.47% <0.00%> (-2.53%) ⬇️
glue_wwt/viewer/table_layer.py 76.73% <0.00%> (-1.99%) ⬇️
glue_wwt/viewer/image_layer.py 33.00% <0.00%> (-0.67%) ⬇️
glue_wwt/viewer/jupyter_viewer.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@astrofrog astrofrog merged commit 02379d0 into glue-viz:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant