Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI envs for PyQt 6.5, 6.6 & Python 3.12; fix Readthedocs #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add CI envs for PyQt 6.5, 6.6 & Python 3.12; fix Readthedocs #17

wants to merge 2 commits into from

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Mar 2, 2024

Description

WIP

@dhomeier dhomeier force-pushed the qt65-6-py312-ci branch 2 times, most recently from 07b7e8b to 1487a9a Compare March 2, 2024 13:46
@dhomeier dhomeier changed the title Add CI envs for PyQt 6.5, 6.6 & Python 3.12 Add CI envs for PyQt 6.5, 6.6 & Python 3.12; fix Readthedocs Mar 2, 2024
@dhomeier
Copy link
Contributor Author

dhomeier commented Mar 2, 2024 •
edited

Same #16 failures on ScatterRegionLayerArtist.enabled.
But there is a new one with Python 3.12 (for PyQt6?) hanging apparently in glue_qt/viewers/matplotlib/tests/test_data_viewer.py:test_add_data_with_subset
until CI timeout; I could not reproduce this latter issue locally.

@dhomeier dhomeier marked this pull request as ready for review March 2, 2024 14:22
@dhomeier
Copy link
Contributor Author

dhomeier commented Mar 4, 2024

@astrofrog it seems I cannot cancel workflows here (might not have the right permissions?), so would rather not experiment more in the CI at this point (haven't tested any py312+PyQT 5 combinations)

@dhomeier
Copy link
Contributor Author

@astrofrog I think #16 may be closed now through glue-viz/glue#2479, but there are 2 new errors probably introduced with glue-viz/glue#2480, e.g. in _update_attribute_display_unit_choices:
https://github.com/glue-viz/glue-qt/actions/runs/8758215189/job/24038566338?pr=17#step:10:687
and on calling Unit(None) from a session file
https://github.com/glue-viz/glue-qt/actions/runs/8758215189/job/24038566338?pr=17#step:10:430

Also all py312 jobs still hanging in test_data_viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dhomeier