Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartridge and Consumable Twig UI #17097

Merged
merged 4 commits into from May 16, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Twig UI and cleanup of Cartridge and Consumable code.

@cconard96 cconard96 added the ui label May 11, 2024
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note, it's worse on current main)

integration of search engine in consumables list in consumable item has broken UI
image

Not sure where the fixed height is set

@cconard96
Copy link
Contributor Author

(note, it's worse on current main)

integration of search engine in consumables list in consumable item has broken UI

Not sure where the fixed height is set

I didn't notice that issue because I didn't interact with the search results when I fixed the UI issue where they were appearing side-by-side. After all this work converting sublists to use the datatable template, this one case where it uses the full search results display with the controls feels very out of place. The "Queries log" tab for webhooks also uses the search result display but without controls so it fits in a little better.

The intent for consumables to have the search engine display was to allow exporting the results and control which columns are shown, but none of the other lists have this same functionality.

@orthagh
Copy link
Contributor

orthagh commented May 13, 2024

The intent for consumables to have the search engine display was to allow exporting the results and control which columns are shown, but none of the other lists have this same functionality.

We may add flags to keep only the export part.
I'm not sure it's that important to have full search controls here

@cconard96
Copy link
Contributor Author

Not sure where the fixed height is set

Actually, it seems less about a fixed height and more that there is only one result so the table is short and the search dropdown has an absolute position so the z-index doesn't apply/work.

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems technically OK.

@cedric-anne cedric-anne merged commit 30d9508 into glpi-project:main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants