Update NetworkEquipment.php - Stacked switch Name with ID

[Mirkk]

Stacked switches got a name with the "description" (model) field added, all switches the same(!), which gives several issues in managing them, and has apparently no logic.

It seems that this was just a wrong copy-paste from the previous code line. Corrected with _$stack_number as a commonly used naming scheme.

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	no ticket

[trasher]

Please provide inventory files examples.

[Mirkk]

networkequipment_0_797.zip
This is a SNMP inventory file for a stacked switch with 2 modules. I heavily reduced and changed it to remove confidential information, keeping only the relevant components "stack" and "chassis". This now generates 2 assets with the same name "SW00Test - 5130EI" and it is impossible to distinguish them, e.g. in a rack. With the fix it will be SW00Test_1 and SW00Test_2.
Works well for all stacks of 2,3,4 (mostly HP) i retrieved so far.
best, Mirko

[trasher]

I made another change. In our existing tests, name already contains the stack number, so the new name was something like "xyz - 1 - 1". I changed a bit the code to keep "xyz - 1" on that cases.

I also added a unit test based on provided file.

[trasher]

@Mirkk are our changes OK for you?

[Mirkk]

Hi, thanks.
just my 2 cents as a php dummy:
With the associativity of ?? this piece is really hard to read, better you put some parentheses please :-)
Moreover isn't the risk to have a result with double "-": "hostname - - 1"?
For the solution itself It is not clear to me why adding the model name (that is it in fact) to the switch name. A single switch has just the hostname. I add another one and it gets also the model name, this is a quite strange behaviour.

As far as I understood from the linked ticket, It could be that "($switch->name ?? $switch->description)" is the stack number on some stacks. However if "$stack_number" is set (and is a number and not "") IMHO it should simply have the precedence, avoiding to add the model name. And you avoid also the check for not adding the number twice.

best
Mirko

[trasher]

The ?? notation is widely used in GLPI code. That's not a problem if you understand the code or not; it's only the result with your network devices that is important.

Existing ones in tests are not affected with latests changes; they were with your initial proposal.

[Mirkk]

Hi,
with this code the result in my case is "SW00Test - 5130EI - 1". Still I have the switch model "5130EI" in the name which is not usual in GLPI. Couldn't it be left out in this case where it is not a number and the stack_numer is present?
If this is not possible for other reasons of course it is fine also like this for my use cases. Thanks a lot!

[trasher]

Since the name/description is present in existing inventories, we have to keep it (and in place) in minor upgrades. Also, it may be something completely different than model or stack number as far as I know.

[Mirkk]

Ok, thanks for your work!