Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for form tags #17089

Merged

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented May 7, 2024

Minimum code to implements form tags.

Form tags are "variables" that will be interpreted when a ticket is created.
It will thus mainly be used to insert the form answers into the created ticket description.

base_tags

I've chosen the # prefix to trigger autocomplete as it is close to the format that was used by formcreator (##TAG##).
No real tags are supplied for now, real content will be provided by the next iterations (questions, answers, ...).

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

@AdrienClairembault AdrienClairembault self-assigned this May 7, 2024
@AdrienClairembault AdrienClairembault force-pushed the feature/forms/tag-base branch 2 times, most recently from 32334d9 to 40591af Compare May 13, 2024 09:54
@AdrienClairembault AdrienClairembault marked this pull request as ready for review May 13, 2024 10:23
@AdrienClairembault
Copy link
Contributor Author

Rebased and forced pushed to latest main state to fix conflicts.

@cedric-anne cedric-anne merged commit 89c1ba3 into glpi-project:main May 15, 2024
8 checks passed
@AdrienClairembault AdrienClairembault deleted the feature/forms/tag-base branch May 15, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants