Fix(Core): Take care of item recursivity to load Dropdown values

[stonebuzz]

Since the release of version 10.0.15 with the following security fix :

d02c537

A user in a sub-entity who views an asset in the root entity (recurisf) can no longer load dropdowns.

When creating the dropdown, the entity_restrict option does not take into account the notion of recursiveness

an empty array is sent

I should see the values visible in the asset entity AND in my current entity (sub-entity)

I think the problem comes from the Session::getMatchingActiveEntities function, which filters theactive entities ($_SESSION) with the desired entity (1 in_array [] => false) (without taking into account the recusivity of the asset).

By adding entity_sons option, GLPI also retrieves the asset's sub-entities, which are then filtered to match the current user's active entities (1 in_array [1] => yes)

This PR deserves special attention because of the complexity of the filtering by entity, because I am not aware of the scope of this change and the criticality involved.

in other words, I don't really know what I'm doing.

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32875

[cedric-anne]

IMHO, we should not be able to edit these fields if the current entity differs from the item entity. Indeed, to be able to edit this field, we should either:

• see all possible dropdown values, including elements that are not supposed to be visible in the current entity (e.g. elements from the same entity as the main item, but with no visibility in child entities);
• see only visible elements in the current entity context, meaning that the current value(s) may be out of the possible values.

[cedric-anne]

As discussed IRL, items are not supposed to be editable when they are displayed outside the entity context. The "update" button is indeed not displayed in this case. The correct fix is probably to change all the form fields to make them "readonly", but is may have many impacts and should be done in the main branch.