Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of old Event class name #17075

Merged

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

There are many pieces of GLPI code that are using something like $itemtype::getTypeName() or new $itemtype() without previously normalizing the $itemtype value using the getItemForItemtype() method. The remaining Event itemtypes values in the database, are probably unsupported since a long time ago.
Anyway, I think the best solution here is to fix values from DB in order to remove the runtime transformation from Event to Glpi\Event.

@cedric-anne cedric-anne self-assigned this May 6, 2024
@cedric-anne cedric-anne added this to the 11.0.0 milestone May 6, 2024
@trasher trasher merged commit d5e7da6 into glpi-project:main May 13, 2024
8 checks passed
@cedric-anne cedric-anne deleted the 11.0/drop-event-itemtype-hack branch May 13, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants