Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Read and Update Owned Rights #17021

Merged
merged 5 commits into from May 7, 2024
Merged

Add Read and Update Owned Rights #17021

merged 5 commits into from May 7, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

cedric-anne
cedric-anne reviewed Apr 29, 2024
View reviewed changes
src/Features/AssignableAsset.php Outdated Show resolved Hide resolved
src/Features/AssignableAsset.php Outdated Show resolved Hide resolved
src/Features/AssignableAsset.php Outdated Show resolved Hide resolved
install/migrations/update_10.0.x_to_11.0.0/assets.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne requested a review from orthagh May 6, 2024 13:55
orthagh
orthagh reviewed May 6, 2024
View reviewed changes
inc/define.php
@@ -68,6 +68,8 @@
define("UNLOCK", 128);
define("READ_ASSIGNED", 256);
define("UPDATE_ASSIGNED", 512);
define("READ_OWNED", 1024);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the answer, but I hope using next bit will not conflict with some stored rights in DB.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see, this value is not used in any assets or assignable items.

orthagh
orthagh approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart the concern about choices of bits (1024, 2048), everything is in the right place.

@cedric-anne cedric-anne added this to the 11.0.0 milestone May 7, 2024
@cedric-anne cedric-anne merged commit d4b49de into glpi-project:main May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@orthagh orthagh orthagh approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cconard96 @orthagh @cedric-anne