Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Adding user tooltip to internal item view #17006

Merged
merged 3 commits into from May 13, 2024
Merged

(Feature) Adding user tooltip to internal item view #17006

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579766a
Fixing login users tooltip display
Lainow May 6, 2024
a515f2d
Apply suggestions from code review
Lainow May 10, 2024
25356d7
Apply suggestions from code review
cedric-anne May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions templates/components/itilobject/selfservice.html.twig
View file
Open in desktop
Expand Up @@ -100,6 +100,10 @@
{% set user_fields = user.fields %}
{% set user_fields = user_fields|merge({user_name: user.getFriendlyName()}) %}
{% set user_fields = user_fields|merge({email: user.getDefaultEmail()}) %}
{% set session_has_read_right = call('Session::haveRight', ['user', constant('READ')]) %}
{% if session_has_read_right %}
Lainow marked this conversation as resolved.
Show resolved Hide resolved
{% set user_fields = user_fields|merge({login: entry_user.fields['name']}) %}
{% endif %}
{{ include('components/user/info_card.html.twig', {
'user': user_fields,
'can_edit': true
Expand Down
4 changes: 4 additions & 0 deletions templates/components/itilobject/timeline/timeline.html.twig
View file
Open in desktop
Expand Up @@ -137,6 +137,10 @@
{% set user_fields = entry_user.fields %}
{% set user_fields = user_fields|merge({user_name: entry_user.getFriendlyName()}) %}
{% set user_fields = user_fields|merge({email: entry_user.getDefaultEmail()}) %}
{% set session_has_read_right = call('Session::haveRight', ['user', constant('READ')]) %}
{% if session_has_read_right %}
Lainow marked this conversation as resolved.
Show resolved Hide resolved
{% set user_fields = user_fields|merge({login: entry_user.fields['name']}) %}
{% endif %}
<span id="timeline-avatar{{ avatar_rand }}">
{{ include('components/user/picture.html.twig', {
'users_id': users_id,
Expand Down
4 changes: 4 additions & 0 deletions templates/components/user/link_with_tooltip.html.twig
View file
Open in desktop
Expand Up @@ -44,6 +44,10 @@
{% set user_fields = user.fields %}
{% set user_fields = user_fields|merge({user_name: user.getFriendlyName()}) %}
{% set user_fields = user_fields|merge({email: user.getDefaultEmail()}) %}
{% set session_has_read_right = call('Session::haveRight', ['user', constant('READ')]) %}
{% if session_has_read_right %}
Lainow marked this conversation as resolved.
Show resolved Hide resolved
{% set user_fields = user_fields|merge({login: user.fields['name']}) %}
{% endif %}
{% do call(
'Html::showToolTip',
[
Expand Down