Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket_List_Color_by_Category #16948

Draft
wants to merge 1 commit into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

AlthausOV
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no assumaebly yes
Deprecations? unknown
Tests pass? unknown
Fixed tickets #number

Hello!

We have an enhancement, where we can define a color by category.

This color is used in the ticket liste for the row background.

This work was don for Version 10.0.14,
not be me :-/

The DB scheme has to be adopted like this:
ALTER TABLE glpi_itilcategories ADD color VARCHAR(255) CHARACTER SET utf32 COLLATE utf32_unicode_ci NULL DEFAULT NULL AFTER color

i dind't find a place in the source for doing that.

This should be read as a proposal...

Greetings from Germany,

Stephan

@AlthausOV
Copy link
Author

image

@AlthausOV
Copy link
Author

Please be patient with me.

The person who wrote this code has unfortunately left our company,
so this is more or less all i have to provide.
As it seems i will look into our local GLPI instance from now on,
and i have to learn about GLPI.

Regards,
Stephan

@trasher
Copy link
Contributor

trasher commented Apr 19, 2024

Hi,

No idea if that feature will be accepted or not but still I have several remarks:

  • no feature will be accepted in 10.0/bugfixes branch, you have to target main branch,
  • modified sql scripts must be provided (install/mysql/glpi-empty.sql and upgrade script - see existing files in migrations/update_10.0.x_to_11.0.0/)
  • take a look at the diff, and please clean it - it's not easy to read as is.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants