New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): Adding radio and checkbox categories and related sub question type #16928
Open
ccailly
wants to merge
2
commits into
glpi-project:main
Choose a base branch
from
ccailly:feature/add-radio-checkbox-types-question-form
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(forms): Adding radio and checkbox categories and related sub question type #16928
ccailly
wants to merge
2
commits into
glpi-project:main
from
ccailly:feature/add-radio-checkbox-types-question-form
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
requested changes
Apr 23, 2024
ccailly
force-pushed
the
feature/add-radio-checkbox-types-question-form
branch
2 times, most recently
from
April 26, 2024 09:37
5baef45
to
3f6f26d
Compare
AdrienClairembault
requested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase and apply the recent changes (input name format + new base class) ?
…ion type fix: JS lint chore: refactor js files to improve code quality chore: split data validation and preparation into separate methods fix: JS lint fix: adding missing abstract methods for urgency question type
ccailly
force-pushed
the
feature/add-radio-checkbox-types-question-form
branch
from
May 6, 2024 09:38
3f6f26d
to
10a5883
Compare
AdrienClairembault
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Radio
andCheckbox
categories and related sub-question type :Radio
andCheckbox