Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): Adding radio and checkbox categories and related sub question type #16928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ccailly
Copy link
Contributor

@ccailly ccailly commented Apr 12, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

Added Radio and Checkbox categories and related sub-question type : Radio and Checkbox

image
image

@ccailly ccailly self-assigned this Apr 12, 2024
@ccailly ccailly added this to the 11.0.0 milestone Apr 12, 2024
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_editor_controller.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
js/form_question_selectable.js Outdated Show resolved Hide resolved
src/Form/QuestionType/AbstractQuestionTypeShortAnswer.php Outdated Show resolved Hide resolved
@ccailly ccailly force-pushed the feature/add-radio-checkbox-types-question-form branch 2 times, most recently from 5baef45 to 3f6f26d Compare April 26, 2024 09:37
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and apply the recent changes (input name format + new base class) ?

…ion type

fix: JS lint

chore: refactor js files to improve code quality

chore: split data validation and preparation into separate methods

fix: JS lint

fix: adding missing abstract methods for urgency question type
@ccailly ccailly force-pushed the feature/add-radio-checkbox-types-question-form branch from 3f6f26d to 10a5883 Compare May 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants