Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Software Twig UI 1 #16913

Merged
merged 2 commits into from Apr 30, 2024
Merged

Software Twig UI 1 #16913

merged 2 commits into from Apr 30, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Based on #16912.
There are a lot of lists, so this work will be split into two PRs.

@cconard96 cconard96 marked this pull request as draft April 10, 2024 01:32
orthagh
orthagh approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a functionnal test in UI, didn't find anything broken.
Seems good so far (apart unit tests failing)

@cconard96 cconard96 marked this pull request as ready for review April 11, 2024 13:20
@cconard96 cconard96 added the ui label Apr 11, 2024
cedric-anne
cedric-anne requested changes Apr 16, 2024
View reviewed changes
src/Html.php Outdated Show resolved Hide resolved
src/Html.php Outdated Show resolved Hide resolved
src/Software.php Outdated Show resolved Hide resolved
src/Software.php Outdated Show resolved Hide resolved
src/SoftwareLicense.php Show resolved Hide resolved
src/SoftwareVersion.php Outdated Show resolved Hide resolved
src/SoftwareVersion.php Outdated Show resolved Hide resolved
src/SoftwareVersion.php Show resolved Hide resolved
cedric-anne
cedric-anne reviewed Apr 29, 2024
View reviewed changes
src/Software.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne merged commit df7f071 into glpi-project:main Apr 30, 2024
8 checks passed
@cedric-anne cedric-anne added this to the 11.0.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cconard96 @orthagh @cedric-anne