Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix business rule using ticket validation #16885

Open
wants to merge 2 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

RomainLvr
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !32312

Fixed a bug that blocked business rules using ticket validation coupled with other criteria.

@RomainLvr RomainLvr self-assigned this Apr 3, 2024
Comment on lines +453 to +455
foreach ($item->fields as $key => $value) {
$input[$key] = $value;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this may trigger other rules on unmodified criteria.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, i have to find another solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants