Activate debug mode only when update is actually done

glpi-project · Nov 3, 2022 · b811b98 · b811b98
1 parent 15d23e2
commit b811b98
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/install/update.php b/install/update.php
@@ -122,6 +122,10 @@ function doUpdateDb()
 {
     global $migration, $update;
 
+    // Init debug variable
+    // Only show errors
+    Toolbox::setDebugMode(Session::DEBUG_MODE, 0, 0, 1);
+
     $currents            = $update->getCurrents();
     $current_version     = $currents['version'];
     $current_db_version  = $currents['dbversion'];

diff --git a/src/Update.php b/src/Update.php
@@ -84,10 +84,6 @@ public function initSession()
             $_SESSION = ['glpilanguage' => (isset($this->args['lang']) ? $this->args['lang'] : 'en_GB')];
             $_SESSION["glpi_currenttime"] = date("Y-m-d H:i:s");
         }
-
-       // Init debug variable
-       // Only show errors
-        Toolbox::setDebugMode(Session::DEBUG_MODE, 0, 0, 1);
     }
 
     /**

diff --git a/tests/functionnal/Update.php b/tests/functionnal/Update.php
@@ -66,14 +66,12 @@ public function testInitSession()
         $this->array($_SESSION)->hasKeys([
             'glpilanguage',
             'glpi_currenttime',
-            'glpi_use_mode'
         ])->notHasKeys([
+            'glpi_use_mode',
             'debug_sql',
             'debug_vars',
             'use_log_in_files'
         ]);
-        $this->variable($_SESSION['glpi_use_mode'])->isIdenticalTo(\Session::DEBUG_MODE);
-        $this->variable(error_reporting())->isIdenticalTo(E_ALL | E_STRICT);
     }
 
     public function testSetMigration()