Improve Aruba SSID detection #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-bougard
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Hi @eduardomozart,
Thank you for this contribution.
I'm okay with your algorithm. I only see few perl language related minor mistakes easy to fix.
|
Another point, packaging building is failing and I've included fixes in develop branch. Can you rebase your branch to include that GH Actions fixes ? |
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Hello, I've applied your changes and tested them on production, they seem to be working fine. Also rebase my repo. |
g-bougard
approved these changes
Apr 24, 2024
|
If merged, glpi-project/glpi#16995 will enable import of ifType 188 by default in next major GLPI release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #657 but for Aruba IAP devices, replacing ifName (e.g.
radioX_ssid_idY) by it's respective SSID name.Please notice that for this enhancement works as expected it's need to mark
188iftype importable as discussed in glpi-project/glpi#16981XML GLPI Agent inventory for Aruba AP:
Before applying this fix: networkequipment_0_8.xml.txt
After applying this fix: networkequipment_0_8_PR658.xml.txt
snmpwalk file for Aruba AP:
arubaiap.walk.txt