Improve Email follow-ups configuration and fix missing logo #125
Conversation
- Fix some lists, the missing linebreak was causing Sphinx treating it as a paragraph. - Use a table to improve readability for global configuration options. - Add additional info about IMAP OAth (internal link) - Add missing GLPI logo. It's now shown on top of sidebar. - Minor fixes
|
Looks good to me, except maybe the logo (blue logo on blue background). The white version of this logo may look better here (pics/logos/logo-GLPI-25-white.png in the GLPI files). |
|
Hi, @cconard96! Thanks for your feedback. I've updated the image. |
| - Max delivery retries - Number times GLPI will try to send a notification. | ||
| - Try to deliver again in (minutes) - Time between notification delivery attempts. | ||
|
|
||
| +------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ |
There was a problem hiding this comment.
I'm not sure table is the better option for display; it currently adds an horizontal scroll :/
There was a problem hiding this comment.
Hmmm...
I'm working on it. There's something called Line blocs that I think can be useful to solve both problems:
- Horizontal scrolling (adding more line breaks)
- The need to declare the
brsnippet. That can be useful, but I think it's better to avoid it.
Line blocks even works on tables (I was not sure about this). The code:
+------------------------------------------------------+------------------------------------------------------------------------------------------------+
| **Option** | **Meaning** |
+------------------------------------------------------+------------------------------------------------------------------------------------------------+
| `Administrator email` | | GLPI Administrator email. |
| | | This can be used as a special recipient in notifications |
+------------------------------------------------------+------------------------------------------------------------------------------------------------+
Generates:
I'm working on a CSS custom rule to avoid the added below line space. Editing the following rule (only for the table(s), of course) looks to solve the problem:
Waiting for feedback on how to continue. Thanks!
There was a problem hiding this comment.
[...]
Line blocks even works on tables (I was not sure about this). The code:
Sounds good to me :) I also agree it would be better not to declare br at all.
I'm working on a CSS custom rule to avoid the added below line space. Editing the following rule (only for the table(s), of course) looks to solve the problem:
[...]
👍
There was a problem hiding this comment.
Updated. Waiting for your review :)
There was a problem hiding this comment.
This is way better, thank you :)
This commit updates the email_notifications.rst file to, instead of the previously declared and used |br| html snippet, use the Sphinx 'Line block' feature. Adding the correct line breaks on the line blocks prevent the horizontal scrolling on the table. Because of this use, a margin was added below the last line. A custom CSS rule is added to prevent this behavior. To add the custom CSS, the conf.py has been updated. Minor grammatical fixes on other files.
Build preview:
