Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of optimizing hyperparameters for handwriting recognition #57

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Nov 11, 2022

Thank you @shihkual for this addition for our poster at MIDAS!

@cbkerr cbkerr requested review from a team as code owners November 11, 2022 18:13
@cbkerr cbkerr requested review from kidrahahjo and syjlee and removed request for a team November 11, 2022 18:13
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • workflow.py and label.py seem unnecessary, especially when functions are refactored, move to project.py.

I did not have an opportunity to view the VAE code any any depth currently, but I will when these changes are addressed.

projects/flow.pytorch.HyperparameterOptimize/init.py Outdated Show resolved Hide resolved
Comment on lines 266 to 272
plt.figure(figsize=(12, 10))
plt.scatter(z1_arr, z2_arr, c=colormap(c_arr), s=5)
plt.colorbar(sm, ticks=np.linspace(0, 10, 10, endpoint=False), label="Ground truth")
plt.xlabel(r"$z_1$", fontsize=25)
plt.ylabel(r"$z_2$", fontsize=25)
plt.title(title_name, fontsize=35)
plt.savefig(job.fn("latent.jpg"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use object oriented interface.

projects/flow.pytorch.HyperparameterOptimize/project.py Outdated Show resolved Hide resolved
projects/flow.pytorch.HyperparameterOptimize/project.py Outdated Show resolved Hide resolved
@b-butler b-butler requested review from tommy-waltmann and removed request for kidrahahjo, syjlee and shihkual October 12, 2023 20:35
Copy link

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be in good shape, there appear to be CI issues and there is one small thing that I thought I should mention.

projects/flow.pytorch.HyperparameterOptimize/source/vae.py Outdated Show resolved Hide resolved
@b-butler
Copy link
Member

PyTorch is not yet available and won't until pytorch/pytorch#112882 is merged, so we will have to wait to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants