Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy from 1.19.4 to 1.19.5 #490

Merged
merged 2 commits into from Jan 13, 2021
Merged

Bump numpy from 1.19.4 to 1.19.5 #490

merged 2 commits into from Jan 13, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 8, 2021

Bumps numpy from 1.19.4 to 1.19.5.

Release notes

Sourced from numpy's releases.

v1.19.5

NumPy 1.19.5 Release Notes

NumPy 1.19.5 is a short bugfix release. Apart from fixing several bugs, the main improvement is the update to OpenBLAS 0.3.13 that works around the windows 2004 bug while not breaking execution on other platforms. This release supports Python 3.6-3.9 and is planned to be the last release in the 1.19.x cycle.

Contributors

A total of 8 people contributed to this release. People with a "+" by their names contributed a patch for the first time.

  • Charles Harris
  • Christoph Gohlke
  • Matti Picus
  • Raghuveer Devulapalli
  • Sebastian Berg
  • Simon Graham +
  • Veniamin Petrenko +
  • Bernie Gray +

Pull requests merged

A total of 11 pull requests were merged for this release.

  • #17756: BUG: Fix segfault due to out of bound pointer in floatstatus...
  • #17774: BUG: fix np.timedelta64('nat').__format__ throwing an exception
  • #17775: BUG: Fixed file handle leak in array_tofile.
  • #17786: BUG: Raise recursion error during dimension discovery
  • #17917: BUG: Fix subarray dtype used with too large count in fromfile
  • #17918: BUG: 'bool' object has no attribute 'ndim'
  • #17919: BUG: ensure _UFuncNoLoopError can be pickled
  • #17924: BLD: use BUFFERSIZE=20 in OpenBLAS
  • #18026: BLD: update to OpenBLAS 0.3.13
  • #18036: BUG: make a variable volatile to work around clang compiler bug
  • #18114: REL: Prepare for the NumPy 1.19.5 release.

Checksums

MD5

2651049b70d2ec07d8afd7637f198807  numpy-1.19.5-cp36-cp36m-macosx_10_9_x86_64.whl
71cc7869a54cf55df4699aebe27e9344  numpy-1.19.5-cp36-cp36m-manylinux1_i686.whl
28d23e25c6e6654b2f65218c6e9b3825  numpy-1.19.5-cp36-cp36m-manylinux1_x86_64.whl

... (truncated)

Commits
  • 8f4b73a REL: NumPy 1.19.5 release.
  • 6485c65 Merge pull request #18114 from charris/maintenance/1.19.x
  • 4862e8f REL: Prepare for the NumPy 1.19.5 release.
  • 827440d Merge pull request #18036 from charris/backport-18030
  • c1b160b BUG: make a variable volatile to work around clang compiler bug (#18030)
  • 82cd407 Merge pull request #18026 from charris/backport-18011
  • bb69625 BLD: update to OpenBLAS 0.3.13
  • 8ab99be Merge pull request #17786 from seberg/bad-array-recursion-error
  • 6f9223c BUG: Raise recursion and memory error during dimension discovery
  • eeaf12d Merge pull request #17924 from charris/backport-17759
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Jan 8, 2021
@dependabot dependabot bot requested a review from jsnel January 8, 2021 17:01
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #490 (d6bdaa8) into master (39713e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #490   +/-   ##
======================================
  Coverage    69.9%   69.9%           
======================================
  Files          57      57           
  Lines        3285    3285           
  Branches      606     606           
======================================
  Hits         2299    2299           
  Misses        856     856           
  Partials      130     130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39713e4...d6bdaa8. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/pip/numpy-1.19.5 branch 2 times, most recently from 6b957e3 to f9d31b6 Compare January 12, 2021 22:20
Bumps [numpy](https://github.com/numpy/numpy) from 1.19.4 to 1.19.5.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/master/doc/HOWTO_RELEASE.rst.txt)
- [Commits](numpy/numpy@v1.19.4...v1.19.5)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/numpy-1.19.5 branch from f9d31b6 to eb7da3c Compare January 12, 2021 22:30
@jsnel jsnel requested a review from s-weigand January 12, 2021 22:35
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took note of the numpy release note, hopefully this means the exception in setup.py and requirements_dev.txt can be eliminated.

NumPy 1.19.5 is a short bugfix release. Apart from fixing several bugs, the main improvement is the update to OpenBLAS 0.3.13 that works around the windows 2004 bug while not breaking execution on other platforms. This release supports Python 3.6-3.9 and is planned to be the last release in the 1.19.x cycle.

@@ -8,7 +8,7 @@ bump2version>=0.5.11
# glotaran setup dependencies
asteval==0.9.21
numpy==1.19.4; sys_platform != "win32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception can now be eliminated @s-weigand ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so, but better to test it locally (with the bad windows patch state see numpy/numpy#16744 (comment)) first. 😉

Pinned minimum numpy version to 1.19.5
@jsnel jsnel self-requested a review January 12, 2021 23:49
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes I made ^^

Changing the minimum numpy version to the latest supported version that is still compatible with the minium version of Python we ever supported (Python 3.6) and is compatible up to at least Python 3.9 seems like a sensible approach.

@jsnel jsnel removed the request for review from s-weigand January 13, 2021 00:04
@jsnel jsnel merged commit 3e5f23c into master Jan 13, 2021
@jsnel jsnel deleted the dependabot/pip/numpy-1.19.5 branch January 13, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants