New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump numpy from 1.19.4 to 1.19.5 #490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
======================================
Coverage 69.9% 69.9%
======================================
Files 57 57
Lines 3285 3285
Branches 606 606
======================================
Hits 2299 2299
Misses 856 856
Partials 130 130 Continue to review full report at Codecov.
|
6b957e3
to
f9d31b6
Compare
Bumps [numpy](https://github.com/numpy/numpy) from 1.19.4 to 1.19.5. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/master/doc/HOWTO_RELEASE.rst.txt) - [Commits](numpy/numpy@v1.19.4...v1.19.5) Signed-off-by: dependabot[bot] <support@github.com>
f9d31b6
to
eb7da3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took note of the numpy release note, hopefully this means the exception in setup.py and requirements_dev.txt can be eliminated.
NumPy 1.19.5 is a short bugfix release. Apart from fixing several bugs, the main improvement is the update to OpenBLAS 0.3.13 that works around the windows 2004 bug while not breaking execution on other platforms. This release supports Python 3.6-3.9 and is planned to be the last release in the 1.19.x cycle.
requirements_dev.txt
Outdated
@@ -8,7 +8,7 @@ bump2version>=0.5.11 | |||
# glotaran setup dependencies | |||
asteval==0.9.21 | |||
numpy==1.19.4; sys_platform != "win32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exception can now be eliminated @s-weigand ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so, but better to test it locally (with the bad windows patch state see numpy/numpy#16744 (comment)) first. 😉
Pinned minimum numpy version to 1.19.5
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the changes I made ^^
Changing the minimum numpy version to the latest supported version that is still compatible with the minium version of Python we ever supported (Python 3.6) and is compatible up to at least Python 3.9 seems like a sensible approach.
Bumps numpy from 1.19.4 to 1.19.5.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
8f4b73a
REL: NumPy 1.19.5 release.6485c65
Merge pull request #18114 from charris/maintenance/1.19.x4862e8f
REL: Prepare for the NumPy 1.19.5 release.827440d
Merge pull request #18036 from charris/backport-18030c1b160b
BUG: make a variable volatile to work around clang compiler bug (#18030)82cd407
Merge pull request #18026 from charris/backport-18011bb69625
BLD: update to OpenBLAS 0.3.138ab99be
Merge pull request #17786 from seberg/bad-array-recursion-error6f9223c
BUG: Raise recursion and memory error during dimension discoveryeeaf12d
Merge pull request #17924 from charris/backport-17759Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually