[121] Update libraries batch-2 #126
Conversation
stanislaw-zakrzewski
added
the
work in progress
stanislaw-zakrzewski
removed
the
work in progress
stanislaw-zakrzewski
changed the title
| @@ -96,7 +97,7 @@ describe('<LandingPage />', () => { | |||
| }); | |||
|
|
|||
| describe('<SignInForm />', () => { | |||
| it('renders and submits form', async () => { | |||
| it.skip('renders and submits form', async () => { | |||
There was a problem hiding this comment.
Are these temporary skips? Will be good to create an issue to keep track if it needs to be un-skipped
There was a problem hiding this comment.
Yes, I indended to create an issue fot "unskipping" the tests, but I must have forgotten. Here it is:
#129
| ENV REACT_APP_MAP_LINK_QA "http://map.marburg.global.health/" | ||
| ENV VITE_APP_DISEASE_NAME "Mpox" | ||
| ENV VITE_APP_MAP_LINK_DEV "http://dev-map.marburg.global.health/" | ||
| ENV VITE_APP_MAP_LINK_LOCAL "http://dev-map.marburg.global.health/" |
There was a problem hiding this comment.
Can these be left blank or made consistent? Right now disease is Mpox but URLs are marburg
There was a problem hiding this comment.
This is an issue that I and Jim found during deploying the app. In order to deploy build is run on the CuratorUI and for build env variables are set. This problem has been already solved partially for the other variables like disease name, which is queried from backend. Same solution can be employed also for map related variables. I can create an issue for that.
Partly solves: #121