New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart refit #829
base: master
Are you sure you want to change the base?
Smart refit #829
Conversation
Is the new function meant to be exported? I suggest adding an example of how it should be used. I tried to make one (expecting it would work the same as
|
If it can be debugged and made robust (and if benchmarking suggests it's worth it), I'd like to roll it into |
Your examples above should work (or throw an informative error) now. There was one simple/thinko bug, plus I didn't test for different length/storage mode of new response. If/when this gets included (whether on its own or as an option to |
I've integrated this into PS I didn't actually CHECK THE RESULTS -- seems fast but wrong! Will have to see what's going on ... |
this may or may not be finished, but I think it might be sufficiently useful to merge?