Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-ASCII characters in emoji names #2572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JadedCtrl
Copy link

Tweaks the emoji shortcode regex to allow non-ASCII alphanumeric characters; this is for internationalization, to allow emoji names to be in languages that don’t fall within ASCII.

@JadedCtrl
Copy link
Author

Non-ASCII emoji-names are currently allowed in Pleroma.

This PR was also sent to upstream Mastodon, and rejected on anglocentric grounds:
mastodon#27809
mastodon#28572

@jakkarth
Copy link

Sadly not a maintainer here but I'd also enjoy having this functionality.

@ClearlyClaire
Copy link

I agree with mastodon#28572 (comment) on the specific example, but I see the value in allowing non-ASCII characters in such identifiers.

Since it's not going to be accepted by upstream Mastodon, I'm not sure it's worth allowing local non-ASCII custom emoji shortcodes, but I think allowing non-ASCII shortcodes for remote custom emoji makes sense. This will prevent copying them as-is, though, so that would require some special handling…

@smiba
Copy link

smiba commented Feb 18, 2024

[...] I'm not sure it's worth allowing local non-ASCII custom emoji shortcodes, but I think allowing non-ASCII shortcodes for remote custom emoji makes sense

Keep in mind there are mastodon instances in languages this very moment that do not fit the ASCII character set (Instances in Japanese, Mandarin, Hindi and the list goes on)
It might feel like a useless feature for us in the west as the majority of our languages fit ASCII perfectly fine, but those other languages have no other choice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants