Add support for viewing MFM (Misskey Flavored Markdown) #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs animation toggle
frontend no longer treats delegated domain mentions as misleading
|
Would really love this in glitch-soc! Find it very odd to see Misskey posts utilizing MFM on my Masto-timeline not rendering anything correctly. |
|
All implemented test cases now pass- That doesn't mean parsing is complete though, test cases for blockquotes for example haven't been written. I'll implement blockquotes and whatever else is left soon and then I'll take a look at having the animations be toggleable. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there's interest for this but it's something I've wanted for a while for myself, and thought I'd at least submit a draft PR in case there is any interest. Since MFM conflicts with Markdown a bit, the MFM implementation includes a limited Markdown implementation as well (😭).
This feature is not complete- While MFM tags such as
$[x2 Hi!]work, along with some inline markdown formatting such as emphasis and strong emphasis, some other things like blockquotes aren't implemented yet. There's also some test cases for the markdown parsing that fail still. Another very important blocker is that it's currently not possible for users to disable viewing MFM, and it autoplays all animations, both of which of course need to be fixed for this to be able to be merged.It would probably also be a good idea to allow users of glitch-soc to send their own MFM, but this would require adding a column to the Status table so we store both the MFM source code for instances with support for MFM, along with the normal representation for other instances. I've not touched any database stuff for this PR yet- The way this PR works as of now is recognising MFM in posts and rewriting the MFM as HTML before the post is added to the database like normal.
(This is my second time using Ruby at all, this was made for my own instance and I'm making this PR just in case, no worries if this implementation isn't good enough!)