Fix keyboard navigation changing settings in App settings #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmh this worked and then stopped working when switching branches back and forth, but worked again on a restart. |
When using keyboard navigation `onBlur` and `onChange` on radio buttons caused settings to be changed. Uses `onClick` instead and replaces `onChange` with a noop to prevent react from complaining. Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
Plastikmensch
force-pushed
the
use-onClick-for-local-settings-radio-buttons
branch
from
b51ae06
to
dc2aa6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using keyboard navigation
onBlurandonChangeon radio buttons caused settings to be changed.This replaces both with
onClick