Sub-second accuracy in syslog adapter #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@josegonzalez I'm new to contributing to logspout – are you asking me? I'm not super fluent in Go and the tests around the syslog adapter are a bit of the mystery to me at the moment. Making this opt-in with an environment variable should be super simple even for me, but I'm not sure if that's what you meant by "configurable". |
|
Could this be merged and release, please? |
|
Could this be merged and release, please? |
|
Btw this LGTM ... let me know if repo needs to announce call for co-maintainers. |
|
Yeah we should probably do that - I don't maintain the repo but Im sure there are folks that would want to. |
TomasLukl
approved these changes
Jul 10, 2023
progrium
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than unnecessarily losing timestamp accuracy, this breaks for syslog daemons that expect sub-second accuracy (like
fluentd).