-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/plugin interface #219
base: dev-deprecated
Are you sure you want to change the base?
Feature/plugin interface #219
Conversation
Thanks! I'm going to review this over the week-end. |
@bensinober This may have happened when you created the pull request, due to out of sync branches: your code mostly compiles but chokes on the capabilities sections. You would need to do the same changes with these. For instance, in the FindUser method, there are still direct SQL queries that will fail to compile. |
Quite so, I failed to keep branch aparts when I tested, so the capabilities query slipped through during rebase. Will fix |
05831eb
to
35ba6c6
Compare
Hi @bensinober. While this compiles, I noticed that you changed the FindUser query to not aliasing the user table to |
You're right of couse. Will revert the removal of table alias |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This feature moves sql queries from strings to interface methods so they can be customized per plugin. This way it is easier to separate sql logic from base sql, and write custom plugins.
The main use case is the ability to write a custom plugin that is independent of sql schemas and can be mapped to any existing user database