Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Standalone Builds for Unity 2019.3 #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubenwe
Copy link

@rubenwe rubenwe commented Feb 29, 2020

This should fix #69, #73 and maybe #71.

I used the Dlls from the mono/4.5 folder of Unity.
Builds again on Windowsx64 with Mono and IL2CPP.

@Suyashtnt
Copy link

how do you install these changes?

@Suyashtnt
Copy link

ok, i figured how to but when I build in Windows64 it does not display "open folder" like how I want it to, any fix for this?

@rubenwe
Copy link
Author

rubenwe commented Apr 17, 2020

@Suyashtnt I don't get what exactly you are asking for. If you give a little more context I might be able to help. At least in my project the FolderBrowser-Dialog works with those changes on Windows 64bit Mono and IL2CPP builds.

@rubenwe rubenwe mentioned this pull request May 1, 2020
@sergiosolorzano
Copy link

sergiosolorzano commented May 15, 2020

Hi @rubenwe
Thanks a bunch for your guidance. I can't build for win or mac il2cpp.

Can you please clarify, when you say you use the dlls for mono/4.5 , what assets/plugins folder setup we should have please?

I can't build for win or macosx

My windows settings:

  • moved the contents of StandaloneFileBrowser/Plugins into the unity project Assets/plugin folder
    ookii
    standalonefilebrowserimports
    windowsForms

I also tried with all systems (win, macosx, linux) ticked for standalone settings of each dll at the time of build.

  • Build with il2cpp, API compatilibility level .NET 4.x on Unity 2019.3.13f1

Failed running C:\Program Files\Unity\Hub\Editor\2019.3.13f1\Editor\Data\il2cpp/build/deploy/net471/il2cpp.exe --convert-to-cpp --emit-null-checks --enable-array-bounds-check --dotnetprofile="unityaot" --compile-cpp --libil2cpp-static --platform="WindowsDesktop" --architecture="x64" --configuration="ReleasePlus" --outputpath="drive:unityproject\Temp/StagingArea/Data\Native\GameAssembly.dll" --cachedirectory="drive:unityproject\Assets..\Library/il2cpp_cache" --incremental-g-c-time-slice=3 --profiler-report --map-file-parser="C:/Program Files/Unity/Hub/Editor/2019.3.13f1/Editor/Data/Tools/MapFileParser/MapFileParser.exe" --directory=drive:unityproject/Temp/StagingArea/Data/Managed --generatedcppdir=drive:unityproject/Temp/StagingArea/Data/il2cppOutput

Exception: C:\Program Files\Unity\Hub\Editor\2019.3.13f1\Editor\Data\il2cpp/build/deploy/net471/il2cpp.exe did not run properly!

thanks a bunch !

@rubenwe
Copy link
Author

rubenwe commented May 17, 2020

@sergiosolorzano what I meant by that is that the DLLs I included in this PR are from the Unity installation - they are the mono/4.5 ones from \Editor\Data\MonoBleedingEdge\lib\mono\4.5.

If you want to compare settings you can check out https://github.com/rubenwe/stlvault (requires GIT LFS - see DEVELOPMENT.md). That one builds and works on all OSes with IL2Cpp.

@shinkuan
Copy link

My project successfully built. But when I try to open a folder, it doesn't, and there is no error show up, just nothing happen. How do I fix this?

@shadowfox87
Copy link

Will using the dlls from mono/4.5 also allow you to build for Windows x86? Or only 64-bit?

@chaoslife
Copy link

does it support .net standard2.0 ? @rubenwe

@rubenwe
Copy link
Author

rubenwe commented Oct 1, 2020

@chaoslife depends on what you mean by that. The assemblies are taken from the mono runtime, so they probably don't target .netstandard2.0.

That doesn't mean that this wil cause issue if you select .netstandard2.0 backend. As far as I understand it, in the end you can't be running on .netstandard anyways. You need a concrete runtime and that can be compatible to the standard.

IL2CPP generated output seems to be compatible and the Mono runtime should be too, as the binaries are taken from it.

@Thane5
Copy link

Thane5 commented Apr 1, 2021

My project successfully built. But when I try to open a folder, it doesn't, and there is no error show up, just nothing happen. How do I fix this?

I'm having the same issue after trying this fix. It builds properly, but then the file window never opens.

Edit: Nevermind, switching to .Net 4.x solved it

@Dummiesman
Copy link

Also appears to fix #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Window Failed
10 participants