Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added support for AppleSilicon and upgraded project to Unity 2021.1.12f1 #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tonidurans
Copy link

I'm a long time user of this plugin and I've just faced some problems porting my apps to the new AppleSilicon architecture. This commit simply upgrades the project version to Unity 2021.1.12f1 and changes Xcode project settings to include arm64 in the macOs bundle.

@meganeroppy
Copy link

Hi.
We are having a problem that we cannot open Finder with Application.Open([LOCAL_PATH]) on standalone build for AppleSilicon architecture, although It successfully works on Unity Editor.
This issue might not be quite related to this plugin, but this is because it's possible to open file-select-dialog with it even on standalone build for AppleSilicon architecture, we wonder if there would be any clue to solve this.

Any advise or comment will be very appreciated.

Thanks.

@tonidurans
Copy link
Author

Hi @meganeroppy,

I've tried Application.OpenURL("file://"+Application.dataPath); and it's working fine for me both in Editor and Build on M1 machine. Could it be a problem with the URL?

Regards

@meganeroppy
Copy link

Hi @tonidurans

Thank you for replying.
Now we can nicely open Finder with OpenURL() for build on M1 even we actually didn't change anything.
So it is kind of fuzzy, but anyhow it got solved.
If we face the same issue, we might post it here again.

Thank you so much.

@Mylab6
Copy link

Mylab6 commented Jul 30, 2022

Thank you for fixing this, the package works fine on Mac, tested with Unity 2021 LTS

EliteAsian123 pushed a commit to YARC-Official/YARG that referenced this pull request May 7, 2023
Apparently, the last official update for the StandaloneFileBrowser was in 2018, before the adoption from Apple to AppleSilicon in 2021.
Because of this, it creates a bug when creating a universal build on Unity (Intel + AppleSilicon) making the "Browse" button from the song folder manager not work anymore.

This replaces the current StandaloneFileBrowser.bundle and uses a .bundle (+ .meta) created by tonidurans that has added support to AppleSilicon

Tested using an Intel-based machine running an Intel + Apple Silicon (universal) build.
Still need testing for Apple Silicon.

 tldr: i just grabbed the .bundle + .meta from this pr (gkngkc/UnityStandaloneFileBrowser#116) and put on the project and now it works 👍
EliteAsian123 added a commit to YARC-Official/YARG that referenced this pull request May 15, 2023
* fix: browse button not working on standalone mac

Apparently, the last official update for the StandaloneFileBrowser was in 2018, before the adoption from Apple to AppleSilicon in 2021.
Because of this, it creates a bug when creating a universal build on Unity (Intel + AppleSilicon) making the "Browse" button from the song folder manager not work anymore.

This replaces the current StandaloneFileBrowser.bundle and uses a .bundle (+ .meta) created by tonidurans that has added support to AppleSilicon

Tested using an Intel-based machine running an Intel + Apple Silicon (universal) build.
Still need testing for Apple Silicon.

 tldr: i just grabbed the .bundle + .meta from this pr (gkngkc/UnityStandaloneFileBrowser#116) and put on the project and now it works 👍

* Update Credits.txt

* feat(workflow): request manual activation file

* feat(workflow): setup builder

* chore(workflow): disable linux test (for now)

* chore: remove build.yml + feat: build-mac.yml (12-core)

* chore(workflow/mac-builder): remove need for 12-core machine

got carried away and got long pickup line

* feat(workflow/mac-builder): enable caching

workflow takes 15 MINUTES JUST FOR INSTALLING UNITY

* fix(workflow/mac-builder): wrong build path

* fix(workflow/mac-builder): install missing library

* chore(workflow/mac-builder): use latest version for unity-builder

* feat(workflow/mac-builder): add names for unamed jobs

* feat(workflow/mac-builder): restore nuget packages

* fix(workflow/mac-builder): remove double-quotes

* test(workflow/mac-builder): check what dotnet version is installed

* feat(workflow/mac-builder): merge python commands

* ok i don't know how to use it

* chore(workflow/mac-builder): change unity-builder version to 2.2.0

* feat(workflow/mac-builder): enable continue-on-error on builder job

* chore(workflow/mac-builder): remove python installation

it already comes installed in apparently

* feat(workflow/mac-builder): merge nuget commands

* feat(workflow/mac-builder): add blender installation

* fix(workflow/mac-version): using wrong python version

* chore(workflow/mac-builder): install an older blender version (3.4.1)

* feat(workflow/mac-builder): add compress file

* chore(workflow): change mac workflow file name

* fix(workflow/mac-builder): use another compressor method

* chore(workflow/mac-builder): remove concurrency cancel-in-progress

* feat(workflow/mac-builder): add quarantine command

* fix(workflow/mac-builder): run quarantine as sudo

* chore(workflow/mac-builder): remove quarantine command

* feat(workflow/mac-builder): create dmg

* fix(workflow/mac-builder): fix wrong extension

* chore(workflow/mac-builder): remove retention-days

* fix(workflow/mac-builder): missing && on commands end

* feat(workflow/mac-builder): add continue-on-error on create dmg

* fix(workflow/mac-builder): separate rename dmg to a different job

* Revert "feat(workflow/mac-builder): create dmg"

Revert "feat(workflow/mac-builder): create dmg"

This reverts commit 0bc0e4c.

* feat(workflow/mac-builder): add caching to git lts

* fix(workflow/mac-builder): fix wrong extension (2)

* feat(workflow/mac-builder): add caching to blender

* fix(workflow/mac-builder): blender cache missing folder

* fix(workflow/mac-builder): wrong blenderinstall folder

* feat(workflow/mac-builder): add commit blenderinstall

* chore(workflow/mac-builder): enable dirty build

* fix(workflow/mac-builder): wrong blenderinstall folder

* fix(workflow/mac-builder): remove git reset

* feat(workflow/mac-builder): remove lfs cache

maybe this is causing some errors on build

* feat(workflow/mac-builder): add inputs to workflow_dispatch

* feat(workflow/mac-builder): change from choice to boolean

* feat(workflow/mac-builder): move blenderinstall to temp/ folder

* fix(workflow/mac-builder): temp folder not existing when creating blenderinstall folder

* feat(workflow/mac-builder): remove write access to blender.dmg after install

* feat(workflow/mac-builder): move blenderinstall to runner.temp

* feat(workflow/mac-builder): remove job matrix

* feat(workflow): new mac fixer workflow

* temporary commit: check what files on main folder

* chore(workflow/macbuild-fix): change getLatestRelease package

* chore(workflow/macbuild-fix): fix find and unzip command

* fix(workflow/macbuild-fix): specify type on find and unzip command

* chore(workflow/macbuild-fix): remove unzip command

* fix(workflow/macbuild-fix): wrong zip destination

* chore(workflow/macbuild-fix): remove temporary "ls" command

* fix(workflow/macbuild-fix): reorder permission steps

* chore(workflow/macbuild-fix): change exec to execdir

* chore(workflow/macbuild-fix): remove -print

* (workflow/macbuild-fix): remove check for xattr

* (workflow/macbuild-fix): apply permission recursivly

* feat(workflow/macbuild-fix): add .tar.bz2 type

* feat(workflow/macbuild-fix): add quarantine command

* feat(workflow/mac-builder): add .tar.bz2 option

* fix(workflow/mac-builder): remove unexpected symbol at end of command

* feat(workflow/macbuild-fix): change job name

---------

Co-authored-by: EliteAsian <lavasnakegaming@gmail.com>
Raveler and others added 2 commits April 29, 2024 15:29
The package URL in the readme pointed to the old, unfixed package from the original repo and was confusing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants