Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeGit + SQLite #3585

Merged
merged 68 commits into from Jun 5, 2021
Merged

NodeGit + SQLite #3585

merged 68 commits into from Jun 5, 2021

Conversation

mittalyashu
Copy link
Member

@mittalyashu mittalyashu commented Oct 15, 2019

NOTE: This PR added a major upgrade in Node v14

To know more about this PR, read this issue #170

TODO:

  • Revert back azure-pipeline changes

* Install NodeGit package

* Fix nodegit package installation (#3512)

* Change node_version to 10.16.0

* Define node & electron engines in package.json

* FIX: Add comma after node version engine

* Switch back to latest version of Node@10

* Split script command yarn and yarn build:window

* Update "postinstall" script command to install electron app deps

* Install electron app native deps

* Merge yarn && yarn postinstall && yarn build:linux command

* Test windows pipeline with npm

* Upgrade nodegit & electron-builder package

* Run pipeline in npm

* Run audit fix

* Run install && audit fix

* install & audit fix & postinstall & build:window

* Update build description

* Move yarn to npm

* Update echo command

* Remove electron from engines

* Update npm registry url

* Initialize repo using nodegit

* Use promise instead of async

* git status (nodegit)
@mittalyashu mittalyashu added Git Git related stuff git commit... 🔥 Priority High Work on this right now! labels Oct 15, 2019
@mittalyashu mittalyashu added this to the 0.1.0 milestone Oct 15, 2019
@mittalyashu mittalyashu self-assigned this Oct 15, 2019
@mittalyashu mittalyashu added this to To do in Roadmap via automation Oct 15, 2019
@request-info
Copy link

request-info bot commented Oct 15, 2019

Hey there! We would appreciate if you could provide us more information about what you're trying to accomplish here!

@gitthermal gitthermal deleted a comment Oct 24, 2019
mittalyashu and others added 7 commits November 8, 2019 21:28
* Use nodegit and database instead of simple-git for initialize repository feature

* Disable git features for non-initialized repositories

* Add initialize repository feature from homepage

This commit includes an anti-pattern because of mutating this.isGit prop inside component but this can't be avoided without making some major changes.
* Get & set settings to localStorage

Using if/else statement in beforeCreate lifecycle hook insted of using in vuex store mutation

* Add AutoInit settings to experimental page

* typo: initialize spellings

* Dispatch update to settings store (in single line)

* fix: autoInit undefined value in settings store

#3596 (comment)
@mittalyashu mittalyashu moved this from To do to In progress in Roadmap Dec 24, 2019
KaKi87 and others added 3 commits January 22, 2020 18:17
* auto initialize non-git repository

* Update repositoryItem.vue after `npm run lint:fix`

* Do not initialize new repository on create

* Fix blocking error on new repository creation when folder does not exist

Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>
Incase error event a message can be shown inside the modal.

Reference: #3599 (comment)
Creating a updateIsGitStatus mutation to update isGit value inside repository vuex store.

Database is updated with the required changes with vuex is unaware of the changes which causes is bug to show repository as `isGit: false`.

Reference: #3599 (comment)
@gitthermal gitthermal deleted a comment Jun 5, 2021
@gitthermal gitthermal deleted a comment Jun 5, 2021
@gitthermal gitthermal deleted a comment Jun 5, 2021
@gitthermal gitthermal deleted a comment Jun 5, 2021
@gitthermal gitthermal deleted a comment Jun 5, 2021
@mittalyashu
Copy link
Member Author

Merging this PR without successful build.

@mittalyashu mittalyashu merged commit e69825c into master Jun 5, 2021
@mittalyashu mittalyashu deleted the chore/add-nodegit branch June 5, 2021 17:23
Roadmap automation moved this from In progress to Done Jun 5, 2021
@mittalyashu
Copy link
Member Author

Unsure (don't remember) of the changes this PR contains with respect to #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Git Git related stuff git commit... 🔥 Priority High Work on this right now!
Projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant