fix: secrets found with quotas #1350
Open
+57
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zricethezav Note this change is coming from my organization fork: Checkmarx/gitleaks. If it helps you, I can recreate my other PRs from there. Contact me on Discord if you want to discuss more about cooperation. |
baruchiro
pushed a commit
to Checkmarx/2ms
that referenced
this pull request
Feb 20, 2024
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
I found some rules that returns the value ended with `"`. This happened because missing `secretGroup` value. It is an _hot fix_. For the future, I think we need: 1. Refactor the `validate` function or create another suite of tests with declaration of the expected found secret. 1. Fix the suffix regex to not include the `"`, because even with my change, it only fixes the `Secret` but not the `Match` Original: gitleaks#1350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some rules that returns the value ended with
". This happened because missingsecretGroupvalue.It is an hot fix.
For the future, I think we need:
validatefunction or create another suite of tests with declaration of the expected found secret.", because even with my change, it only fixes theSecretbut not theMatch