Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prepare script to package.json #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dudaerich
Copy link

Since npm@5.0.0 the prepare script is called
when the library is installed from github url.
Aim of the script is to build distribution
files.

See npm/npm#3055

Since npm@5.0.0 the prepare script is called
when the library is installed from github url.
Aim of the script is to build distribution
files.

See npm/npm#3055
@j-rewerts
Copy link
Member

Here is NPM's docs on it. This seems to work for me. It automatically builds the project when I run npm install, which is convenient. I'm still not 100% on how this impacts our build process though, since we support Node 4, which doesn't run this.

I think we should probably wait until we get our tests passing, then rerun our CI for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants